[PATCH] D43729: [CallSiteSplitting] properly split musttail calls

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 10:44:54 PST 2018

fhahn added inline comments.

Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:338
+  // FIXME: remove TI above, once https://reviews.llvm.org/D43822 lands
+  {
+    SmallVector<BasicBlock *, 2> Splits(predecessors((TailBB)));
We  should only do that for musttail calls, otherwise we crash.

I think we hit a slightly different problem here that won't be fixed by D43822. A different iterator gets invalidated. I'll have a closer look tomorrow.


More information about the llvm-commits mailing list