[PATCH] D43948: [ELF] - Report error when memory region is overflowed by data commands.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 10:21:11 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/linkerscript/memory-data-commands.test:12-25
+MEMORY
+{
+  text (rwx): org = 0x0, len = 0x1000
+  ram (rwx): org = 0x1000, len = 8
+}
+SECTIONS
+{
----------------
nit: please format in the same way as other linker scripts. I.e.

  MEMORY {
    text (rwx): org = 0x0, len = 0x1000
    ram (rwx): org = 0x1000, len = 8
  }

  SECTIONS {
    .text : { *(.text) } > text
    .foo  : { *(.foo) BYTE(0x1) } > ram
  }



https://reviews.llvm.org/D43948





More information about the llvm-commits mailing list