[PATCH] D43921: [WebAssembly] Use uint8_t for single byte values to match the spec

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 10:07:43 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D43921#1023974, @dschuff wrote:

> I'm fine with doing this change since it does reflect the spec. Although IIRC the relevant types don't yet have any values over 128 and we've kept it that way so we can always upgrade to varint when we need to. So in principle we could keep the code using varint and then it won't have to change in the future.


I'd rather match the spec than try to guess what the future brings and jump ahead of the spec.


Repository:
  rL LLVM

https://reviews.llvm.org/D43921





More information about the llvm-commits mailing list