[PATCH] D43946: [WebAssembly] Reorder reloc sections to come after symtab

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 09:30:48 PST 2018


sbc100 added a comment.

Interesting that no test changes needed.  I guess its because obj2yaml doesn't display the reloc sections themselves... but injects them into the section they apply to.



================
Comment at: wasm/Writer.cpp:637
-    createRelocSections();
+  if (Config->Relocatable)
     createLinkingSection();
-  }
----------------
Why not just swap these two lines?   I'm not sure we should care about where these sections come relative the name section.   


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43946





More information about the llvm-commits mailing list