[PATCH] D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 07:29:12 PST 2018


ncw added a comment.

In https://reviews.llvm.org/D43675#1021108, @sbc100 wrote:

> Might be easier to add a command line flag to control the name here, rather than changing emscripten?


But we don't do that for other linker-provided symbols like `__wasm_call_ctors `or `__stack_pointer`, so why should we do it for `__linear_memory`? We do provide a commandline-parameter for the entry-point, but that's a user-provided symbol so it's not really the same.

I've made an Emscripten pull request here, to be merged at the same time as this change: https://github.com/kripken/emscripten/pull/6293


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43675





More information about the llvm-commits mailing list