[PATCH] D43627: [DEBUGINFO] Add flag for DWARF2 or less to use sections as references.

Thu Mar 1 06:57:59 PST 2018

ABataev added a comment.

In https://reviews.llvm.org/D43627#1022846, @JDevlieghere wrote:

> I really hate to go on about this, but the truth is that I've been told this so many times that it instantly caught my eye. 😀

1. Several years ago I got a lot of reviews where reviewers insisted(!!!) to enclose multiline (not multistatement!!!) single-statement substatements into braces. I did for the last 6 years and had no problems with it. This is the first time I see this. Di I miss something, the rules changed already?
2. There is a patch https://reviews.llvm.org/D26943, that was accepted but not committed to enclosing multiline (not multistatement) substatements in `if` and `for` statements. It is clear that multistatement substatements must be enclosed and this kind of rule is not required at all.

I'm not against this kind of change but seems to me this is not strictly standardized.

Repository:
  rL LLVM

https://reviews.llvm.org/D43627