[PATCH] D43891: Simplify removing empty output sections

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 14:33:19 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/LinkerScript.cpp:775
 
+static bool isAllSectionDescription(const OutputSection &Cmd) {
+  // We do not remove empty sections that are explicitly
----------------
It feels like this function name is not right because this function does more than checking if all members are section descriptions. Can you rename?


https://reviews.llvm.org/D43891





More information about the llvm-commits mailing list