[PATCH] D43859: [GlobalOpt] don't change CC of musttail calle(e|r) PR36546

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 13:51:52 PST 2018

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D43859#1022602, @indutny wrote:

> Address inline comments.
>  ---
> As far as I can see it, the documentation doesn't say anything about `musttail` in particular. It says that `tail` calls require `fastcc` to be optimized, but even this seems to be rather stale.
> Changing CC for the whole chain is totally a valid alternative. Would it make sense to you if I'll add a `FIXME` comment there?

Alright, that works for me! With the FIXME added this LGTM.


More information about the llvm-commits mailing list