[PATCH] D43627: [DEBUGINFO] Add flag for DWARF2 or less to use sections as references.
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 13:21:58 PST 2018
Oh, sure, I know you need it I just wanted to separate "can we use a
section relocation" from "should we emit these sections". The latter can be
handled the same way we're planning to handle the rest of the conditional
On Wed, Feb 28, 2018 at 1:08 PM Alexey Bataev <a.bataev at outlook.com> wrote:
> Unfortunately, I can't commit everything else without this patch. It will definitely break the compilation of ptx files.
> Best regards,
> Alexey Bataev
> 28.02.2018 16:04, Eric Christopher пишет:
> On Wed, Feb 28, 2018 at 1:02 PM Alexey Bataev via Phabricator <
> reviews at reviews.llvm.org> wrote:
>> ABataev added a comment.
>> In https://reviews.llvm.org/D43627#1022609
>> @echristo wrote:
>> > Using sections as references is, in general, a good idea when we can so
>> I'd rather not tie that to whether or not we emit certain sections. If you
>> don't mind reverting that aspect of the change I'd appreciate it and we can
>> get that in via some other preference or a strict requirement via the asm
>> printer as we're planning on doing for the rest of the nvptx section
>> These sections have labels inside of them + they are not supported by PTX
>> format. Ok, I will revert the patch.
> Sure. Adding back everything else is fine to commit btw. We can worry
> about when to use section relocations rather than label relocations in a
> different patch though.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits