[PATCH] D43627: [DEBUGINFO] Add flag for DWARF2 or less to use sections as references.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 13:04:47 PST 2018

On Wed, Feb 28, 2018 at 1:02 PM Alexey Bataev via Phabricator <
reviews at reviews.llvm.org> wrote:

> ABataev added a comment.
> In https://reviews.llvm.org/D43627#1022609, @echristo wrote:
> > Using sections as references is, in general, a good idea when we can so
> I'd rather not tie that to whether or not we emit certain sections. If you
> don't mind reverting that aspect of the change I'd appreciate it and we can
> get that in via some other preference or a strict requirement via the asm
> printer as we're planning on doing for the rest of the nvptx section
> emission.
> These sections have labels inside of them + they are not supported by PTX
> format. Ok, I will revert the patch.
Sure. Adding back everything else is fine to commit btw. We can worry about
when to use section relocations rather than label relocations in a
different patch though.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/dfd3423d/attachment.html>

More information about the llvm-commits mailing list