[PATCH] D43627: [DEBUGINFO] Add flag for DWARF2 or less to use sections as references.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev marked 2 inline comments as done.
ABataev added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:128
+    "dwarf-sections-as-references", cl::Hidden,
+    cl::desc("Use sections+|-offset as references rather than labels."),
+    cl::values(clEnumVal(Default, "Default for platform"),
----------------
probinson wrote:
> I'd prefer "section+offset" as I doubt you would ever have a reference to something before the start of a section!
Ok, will do


================
Comment at: test/DebugInfo/X86/sections_as_references.ll:6
+; CHECK-NEXT: .file 2 "/dir/tu1.cpp"
+; CHECK-NEXT: .file 3 "/dir/tu2.cpp"
+
----------------
probinson wrote:
> Do you really need to check for .file directives?
No, will remove these checks


Repository:
  rL LLVM

https://reviews.llvm.org/D43627