[PATCH] D43813: [Machine Combiner] Valid use of OptSize

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 04:51:56 PST 2018

avt77 added a comment.

In https://reviews.llvm.org/D43813#1020647, @RKSimon wrote:

> test case?

Unfortunately, before https://reviews.llvm.org/D40602 (or https://reviews.llvm.org/D26855 which I'm going to update soon) we don't have any test case because we don't use Machine Combiner when alternative sequence of instructions is longer then the original one.
But https://reviews.llvm.org/D40602 has such test just now (see lines 420-423 in test/CodeGen/X86/schedule-x86-64-shld.ll): at the moment we can select longer code sequence even if we have optsize option for the function (see define void @lshift_mem_b_optsize(i64 %b) nounwind readnone optsize {).


More information about the llvm-commits mailing list