[PATCH] D43824: [CallSiteSplitting] Do not crash when BB's terminator changes.

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 22:57:48 PST 2018

uabelho added a comment.

In https://reviews.llvm.org/D43824#1020767, @fhahn wrote:

> I am not entirely sure if that's the best solution, but it should work. Maybe it would be nicer to split the pas into an analysis and transformation phase, then we would get rid of the problem.
> @uabelho it would be great if you could check if this patch together with https://reviews.llvm.org/D43824 fixes the regressions you are seeing?

@fhahn: I applied https://reviews.llvm.org/D43822 together with https://reviews.llvm.org/D43824 on top of tree and that made the crash that I saw go away.



More information about the llvm-commits mailing list