[lld] r326293 - [WebAssembly] Simplify Symbol::getWasmType. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 17:10:50 PST 2018


Author: ruiu
Date: Tue Feb 27 17:10:50 2018
New Revision: 326293

URL: http://llvm.org/viewvc/llvm-project?rev=326293&view=rev
Log:
[WebAssembly] Simplify Symbol::getWasmType. NFC.

Differential Revision: https://reviews.llvm.org/D43717

Modified:
    lld/trunk/wasm/Symbols.cpp

Modified: lld/trunk/wasm/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Symbols.cpp?rev=326293&r1=326292&r2=326293&view=diff
==============================================================================
--- lld/trunk/wasm/Symbols.cpp (original)
+++ lld/trunk/wasm/Symbols.cpp Tue Feb 27 17:10:50 2018
@@ -30,19 +30,13 @@ DefinedData *WasmSym::HeapBase;
 DefinedGlobal *WasmSym::StackPointer;
 
 WasmSymbolType Symbol::getWasmType() const {
-  switch (SymbolKind) {
-  case Symbol::DefinedFunctionKind:
-  case Symbol::UndefinedFunctionKind:
+  if (isa<FunctionSymbol>(this))
     return llvm::wasm::WASM_SYMBOL_TYPE_FUNCTION;
-  case Symbol::DefinedDataKind:
-  case Symbol::UndefinedDataKind:
+  if (isa<DataSymbol>(this))
     return llvm::wasm::WASM_SYMBOL_TYPE_DATA;
-  case Symbol::DefinedGlobalKind:
-  case Symbol::UndefinedGlobalKind:
+  if (isa<GlobalSymbol>(this))
     return llvm::wasm::WASM_SYMBOL_TYPE_GLOBAL;
-  default:
-    llvm_unreachable("invalid symbol kind");
-  }
+  llvm_unreachable("invalid symbol kind");
 }
 
 bool Symbol::hasOutputIndex() const {




More information about the llvm-commits mailing list