[lld] r326282 - [WebAssembly] Do not use default arguments for SymbolTable.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Tue Feb 27 16:37:03 2018
New Revision: 326282

URL: http://llvm.org/viewvc/llvm-project?rev=326282&view=rev
Log:
[WebAssembly] Do not use default arguments for SymbolTable.

Differential Revision: https://reviews.llvm.org/D43727

Modified:
    lld/trunk/wasm/Driver.cpp
    lld/trunk/wasm/SymbolTable.h

Modified: lld/trunk/wasm/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Driver.cpp?rev=326282&r1=326281&r2=326282&view=diff
==============================================================================
--- lld/trunk/wasm/Driver.cpp (original)
+++ lld/trunk/wasm/Driver.cpp Tue Feb 27 16:37:03 2018
@@ -300,10 +300,10 @@ void LinkerDriver::link(ArrayRef<const c
         "__wasm_call_ctors", &NullSignature, WASM_SYMBOL_VISIBILITY_HIDDEN);
     WasmSym::StackPointer = Symtab->addSyntheticGlobal(
         "__stack_pointer", WASM_SYMBOL_VISIBILITY_HIDDEN, StackPointer);
-    WasmSym::HeapBase = Symtab->addSyntheticDataSymbol("__heap_base");
+    WasmSym::HeapBase = Symtab->addSyntheticDataSymbol("__heap_base", 0);
     WasmSym::DsoHandle = Symtab->addSyntheticDataSymbol(
         "__dso_handle", WASM_SYMBOL_VISIBILITY_HIDDEN);
-    WasmSym::DataEnd = Symtab->addSyntheticDataSymbol("__data_end");
+    WasmSym::DataEnd = Symtab->addSyntheticDataSymbol("__data_end", 0);
 
     if (!Config->Entry.empty())
       EntrySym = Symtab->addUndefinedFunction(Config->Entry, 0, nullptr,

Modified: lld/trunk/wasm/SymbolTable.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/SymbolTable.h?rev=326282&r1=326281&r2=326282&view=diff
==============================================================================
--- lld/trunk/wasm/SymbolTable.h (original)
+++ lld/trunk/wasm/SymbolTable.h Tue Feb 27 16:37:03 2018
@@ -49,10 +49,10 @@ public:
   ObjFile *findComdat(StringRef Name) const;
 
   Symbol *addDefinedFunction(StringRef Name, uint32_t Flags, InputFile *File,
-                             InputFunction *Function = nullptr);
+                             InputFunction *Function);
   Symbol *addDefinedData(StringRef Name, uint32_t Flags, InputFile *File,
-                         InputSegment *Segment = nullptr, uint32_t Address = 0,
-                         uint32_t Size = 0);
+                         InputSegment *Segment, uint32_t Address,
+                         uint32_t Size);
   Symbol *addDefinedGlobal(StringRef Name, uint32_t Flags, InputFile *File,
                            InputGlobal *G);
 
@@ -65,12 +65,12 @@ public:
   void addLazy(ArchiveFile *F, const Archive::Symbol *Sym);
   bool addComdat(StringRef Name, ObjFile *);
 
-  DefinedData *addSyntheticDataSymbol(StringRef Name, uint32_t Flags = 0);
+  DefinedData *addSyntheticDataSymbol(StringRef Name, uint32_t Flags);
   DefinedGlobal *addSyntheticGlobal(StringRef Name, uint32_t Flags,
                                     InputGlobal *Global);
   DefinedFunction *addSyntheticFunction(StringRef Name,
                                         const WasmSignature *Type,
-                                        uint32_t Flags = 0);
+                                        uint32_t Flags);
 
 private:
   std::pair<Symbol *, bool> insert(StringRef Name);