[PATCH] D43834: Fix use after free in PDB linker.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 16:17:07 PST 2018


zturner added a comment.

Actually now I'm second guessing myself.  This fixes the case where we freed the `BumpPtrAllocator` used for discontiguous records, but when we close the `NativeSession` object, we also close the mapped view of the file.

I think a better fix is to simply keep a strong reference to the type server PDB's session until we're done.


https://reviews.llvm.org/D43834





More information about the llvm-commits mailing list