[PATCH] D43833: [InstCombine] Split the FP constant code out of lookThroughFPExtensions and use nullptr as a sentinel.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 15:54:12 PST 2018

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.


Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1442-1443
 static Value *lookThroughFPExtensions(Value *V) {
   while (auto *FPExt = dyn_cast<FPExtInst>(V))
     V = FPExt->getOperand(0);
Since we're going to fix this: a loop is unnecessary here AFAIK. isEliminableCastPair() would always squash those?


More information about the llvm-commits mailing list