[PATCH] D43697: [WebAssembly] Separate addUndefined into addUndefined{Function, Data, Global}.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 13:32:40 PST 2018

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.

Comment at: lld/wasm/SymbolTable.cpp:111
-    assert(NewGlobalType != nullptr);
-    const WasmGlobalType *OldType = Sym.getGlobalType();
-    if (*NewGlobalType == *OldType)
-      return;
+  if (!Config->CheckSignatures)
+    return;
We don't need this `if`.   The signature checking on functions is optional to allow certain C programs to link.  Shouldn't be needed to wasm globals (which are not used in C).


More information about the llvm-commits mailing list