[PATCH] D43713: [WebAssembly] Inline accessor functions that are called only once.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 13:25:51 PST 2018


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Agreed.  This is mostly a historical legacy since these used to be public method used elsewhere.   I've been meaning to do something like this myself.



================
Comment at: lld/wasm/InputFiles.cpp:68
-uint32_t ObjFile::relocateTypeIndex(uint32_t Original) const {
-  assert(TypeIsUsed[Original]);
-  return TypeMap[Original];
----------------
I think this assert is useful.  It ensures the type is valid and part of the output.


https://reviews.llvm.org/D43713





More information about the llvm-commits mailing list