[llvm] r326215 - [GISel]: Print more fallback information when aborting

Aditya Nandakumar via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 10:04:23 PST 2018


Author: aditya_nandakumar
Date: Tue Feb 27 10:04:23 2018
New Revision: 326215

URL: http://llvm.org/viewvc/llvm-project?rev=326215&view=rev
Log:
[GISel]: Print more fallback information when aborting

Currently when abort is enabled, we get a diagnostic saying "Fallback
path used .... " and the program terminates. To actually figure out what
the reason is, we need to run again with another verbose argument
"-pass-remarks-missed=gisel". Instead, when we are going to abort,
we might as well print expensive remarks.

https://reviews.llvm.org/D43796

Modified:
    llvm/trunk/lib/CodeGen/GlobalISel/Utils.cpp

Modified: llvm/trunk/lib/CodeGen/GlobalISel/Utils.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/Utils.cpp?rev=326215&r1=326214&r2=326215&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/Utils.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/Utils.cpp Tue Feb 27 10:04:23 2018
@@ -168,7 +168,7 @@ void llvm::reportGISelFailure(MachineFun
                                     MI.getDebugLoc(), MI.getParent());
   R << Msg;
   // Printing MI is expensive;  only do it if expensive remarks are enabled.
-  if (MORE.allowExtraAnalysis(PassName))
+  if (TPC.isGlobalISelAbortEnabled() || MORE.allowExtraAnalysis(PassName))
     R << ": " << ore::MNV("Inst", MI);
   reportGISelFailure(MF, TPC, MORE, R);
 }




More information about the llvm-commits mailing list