[PATCH] D43414: AMDGPU: Define FP_FAST_FMA{F} macros for amdgcn

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 05:41:47 PST 2018

b-sumner added inline comments.

Comment at: lib/Basic/Targets/AMDGPU.cpp:346-347
-  if (hasFMAF)
+  // TODO: __HAS_FMAF__, __HAS_LDEXPF__, __HAS_FP64__ are deprecated and will be
+  // removed in the near future.
+  if (GPU.HasFMAF)
t-tye wrote:
> @b-sumner which ones were to recommending deprecating? I would think FP64 and FMAF would be ones that needs to be kept? I thought it was __HAS_FAST_FMA__ that is not specified by OpenCL.
Sorry, I was referring to all of the __HAS_* macros.


More information about the llvm-commits mailing list