[PATCH] D43329: [SystemZ, MachineScheduler] Refactor GenericScheduler::tryCandidate() to reuse parts in a new SystemZ scheduling strategy.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 00:25:03 PST 2018


jonpa added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:157
 
+namespace llvm { namespace SISched {
 static bool tryLess(int TryVal, int CandVal,
----------------
fhahn wrote:
> nit: not sure, should nested namespaces be separated by newlines?
I copied this from the PowerPC backend, but looking at the "Namespace Indentation" section of the coding guidlines, it seems that at least in the example there newlines are used, so it seems you are right.



https://reviews.llvm.org/D43329





More information about the llvm-commits mailing list