[PATCH] D43093: [FastISel] Sink local value materializations to first use

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 17:22:49 PST 2018

rnk added a comment.

In https://reviews.llvm.org/D43093#1016883, @MatzeB wrote:

> Looks good from what I can see, though I'm not super experienced with fast-isel either. Does this work correctly in the case when fast-isel aborts while selecting a block?

Thanks for reading, though. :) I believe the mid-block abort case came up during testing and is covered by the existing suite. FastISel often aborts on calls, flushes the local value area, goes to sdag to select a single call instruction, and then continues fastisel. This all seems to work. When it aborts, it flushes the local value area, which now triggers sinking.


More information about the llvm-commits mailing list