[PATCH] D43739: [ValueTracking] Teach cannotBeOrderedLessThanZeroImpl to handle vector constants.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a reviewer: RKSimon.
spatel added a comment.

This is an improvement, so I won't hold it up if you want to get it committed...

But I wonder if here - and maybe also for https://reviews.llvm.org/D43774 - we can enhance PatternMatching for FP as we've recently done for integer with:
https://reviews.llvm.org/D42818
https://reviews.llvm.org/rL325466

The benefit is that those can also match vectors with undef lanes. Also, once we have that templated in PatternMatch, we won't have to keep rewriting this vector-constant loop with getAggregateElement(). I was looking at adding that anyway to improve some FP instcombines, but I hadn't gotten there yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D43739