[PATCH] D43739: [ValueTracking] Teach cannotBeOrderedLessThanZeroImpl to handle vector constants.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 26 13:10:10 PST 2018
spatel added a reviewer: RKSimon.
spatel added a comment.
This is an improvement, so I won't hold it up if you want to get it committed...
But I wonder if here - and maybe also for https://reviews.llvm.org/D43774 - we can enhance PatternMatching for FP as we've recently done for integer with:
The benefit is that those can also match vectors with undef lanes. Also, once we have that templated in PatternMatch, we won't have to keep rewriting this vector-constant loop with getAggregateElement(). I was looking at adding that anyway to improve some FP instcombines, but I hadn't gotten there yet.
More information about the llvm-commits