[PATCH] D43702: [asan] Fix bug where suppression of overlapping accesses was ignored.

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: test/asan/TestCases/strncpy-overlap.cc:29
+  // CHECK: [{{0x.*,[ ]*0x.*}}) and [{{0x.*,[ ]*0x.*}}) overlap
+  // CHECK-Linux: {{#0 0x.* in .*strncpy}}
+  // CHECK-Darwin: {{#0 0x.* in wrap_strncpy}}
----------------
kubamracek wrote:
> delcypher wrote:
> > kubamracek wrote:
> > > Since the "Linux" line is matching the Darwin output as well, can we just use the Linux version?
> > We could do. I think I copied the regex from the existing in `strncpy-overflow.cc` test. Is that test a bad example of how to do things?
> It's not a big deal, but it just seems unnecessary to complicate this test with OS specific checks.
Thinking more about it, I don't see a good reason why the two OS's should differ in behavior here anyway. At some point, we should probably stop printing the "wrap_" prefix on Darwin (it's just a side effect of how interceptors work on Darwin).


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43702