[llvm] r326096 - Revert r326092: [gtest] Add PrintTo overload for StringRef.

Ilya Biryukov via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 07:54:59 PST 2018


Author: ibiryukov
Date: Mon Feb 26 07:54:59 2018
New Revision: 326096

URL: http://llvm.org/viewvc/llvm-project?rev=326096&view=rev
Log:
Revert r326092: [gtest] Add PrintTo overload for StringRef.

It seems to break the following buildbot:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/24729

Will resubmit after investigating and fixing it.

Modified:
    llvm/trunk/utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h

Modified: llvm/trunk/utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h?rev=326096&r1=326095&r2=326096&view=diff
==============================================================================
--- llvm/trunk/utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h (original)
+++ llvm/trunk/utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h Mon Feb 26 07:54:59 2018
@@ -39,17 +39,4 @@
 #ifndef GTEST_INCLUDE_GTEST_INTERNAL_CUSTOM_GTEST_PRINTERS_H_
 #define GTEST_INCLUDE_GTEST_INTERNAL_CUSTOM_GTEST_PRINTERS_H_
 
-#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/raw_os_ostream.h"
-#include <cassert>
-
-namespace llvm {
-// Without this overload StringRef will be printed as a generic container.
-inline void PrintTo(const llvm::StringRef &Val, std::ostream *S) {
-  assert(S);
-  llvm::raw_os_ostream OS(*S);
-  OS << Val;
-}
-} // namespace llvm
-
 #endif  // GTEST_INCLUDE_GTEST_INTERNAL_CUSTOM_GTEST_PRINTERS_H_




More information about the llvm-commits mailing list