[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

Leandro Lupori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 07:32:45 PST 2018

luporl added a comment.

In https://reviews.llvm.org/D42582#1017455, @labath wrote:

> I don't think I know enough about this, so I'll defer to Jim to comment on the design. I just have some comments about the implementation.
> Also, it looks like at least the breakpoint-setting part should be easy to test in a freestanding environment: make a .s file which sets up the function, llvm-mc it, load it up in lldb, set a breakpoint, verify it got moved to the right offset. I've been playing around with a patch that should make this easier for you. I'll see if I can clean it up and upload today...

Do you think we need a separate test for this? There are already at least 2 tests that always fail without the breakpoint fix: TestDeadStrip and TestBacktraceAll.


More information about the llvm-commits mailing list