[PATCH] D37054: Require address space to be specified when creating functions (2/3)

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

Thanks for working on this, it will make life a lot easier for us when it lands.



================
Comment at: lib/AsmParser/LLParser.cpp:4893
     FunctionType::get(RetType, ParamTypeList, isVarArg);
   PointerType *PFT = PointerType::getUnqual(FT);
 
----------------
As @bjope  says this should use `PointerType::get(FT, AddrSpace)`

In our fork (https://github.com/CTSRD-CHERI/llvm / https://github.com/CTSRD-CHERI/clang) I have removed all uses of `PointerType::getUnqual()` from clang and most of them from LLVM since they almost always cause issues for us.


https://reviews.llvm.org/D37054