[PATCH] D38128: Handle COPYs of physregs better (regalloc hints)

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa marked an inline comment as done.
jonpa added inline comments.


================
Comment at: test/CodeGen/XCore/byVal.ll:45-46
 ; CHECK: stw r0, sp[2]
-; CHECK: ldaw r2, sp[2]
+; CHECK: ldaw r1, sp[2]
 ; CHECK: mov r0, r1
 ; CHECK: bl f2
----------------
robertlytton wrote:
> Hi jonpa,
> The output in test/CodeGen/XCore/byVal.ll is incorrect.
> viz the value in r1 is not copied into r0 before being overwritten by the value in sp[2] (r0's indirected value).
> These two lines should be the other way around.
> sorry
> robert
> 
> 
Ah, I think 'r1' slipped through in the place of 'r11'... Does it look ok now?


https://reviews.llvm.org/D38128