[PATCH] D43539: Add new interceptors: getttyent(3) family

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: test/sanitizer_common/TestCases/NetBSD/getttyent.cc:13
+  typ = getttyent();
+  if (!typ)
+    exit(1);
----------------
test would be cleaner without 
if (!typ) exit(1);

if it nullptr it will fail anyway at printf 


================
Comment at: test/sanitizer_common/TestCases/NetBSD/getttyent.cc:45
+
+  typ = getttyent();
+  if (!typ)
----------------
Could you please combine declaration and initialization here and the rest?
struct ttyent *typ = getttyent();


Repository:
  rL LLVM

https://reviews.llvm.org/D43539