[PATCH] D38128: Handle COPYs of physregs better (regalloc hints)

robert lytton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 25 09:53:59 PST 2018


robertlytton requested changes to this revision.
robertlytton added a comment.
This revision now requires changes to proceed.

please see in-line comments



================
Comment at: test/CodeGen/XCore/byVal.ll:45-46
 ; CHECK: stw r0, sp[2]
-; CHECK: ldaw r2, sp[2]
+; CHECK: ldaw r1, sp[2]
 ; CHECK: mov r0, r1
 ; CHECK: bl f2
----------------
Hi jonpa,
The output in test/CodeGen/XCore/byVal.ll is incorrect.
viz the value in r1 is not copied into r0 before being overwritten by the value in sp[2] (r0's indirected value).
These two lines should be the other way around.
sorry
robert




https://reviews.llvm.org/D38128





More information about the llvm-commits mailing list