[PATCH] D43711: [WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.

[WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC.


https://reviews.llvm.org/D43711

Files:
  lld/wasm/Symbols.h


Index: lld/wasm/Symbols.h
===================================================================
--- lld/wasm/Symbols.h
+++ lld/wasm/Symbols.h
@@ -39,23 +39,26 @@
     DefinedFunctionKind,
     DefinedDataKind,
     DefinedGlobalKind,
-
-    LazyKind,
     UndefinedFunctionKind,
     UndefinedDataKind,
     UndefinedGlobalKind,
-
-    LastDefinedKind = DefinedGlobalKind,
+    LazyKind,
   };
 
   Kind kind() const { return SymbolKind; }
 
-  bool isLazy() const { return SymbolKind == LazyKind; }
-  bool isDefined() const { return SymbolKind <= LastDefinedKind; }
+  bool isDefined() const {
+    return SymbolKind == DefinedFunctionKind ||
+           SymbolKind == DefinedDataKind || SymbolKind == DefinedGlobalKind;
+  }
+
   bool isUndefined() const {
     return SymbolKind == UndefinedFunctionKind ||
            SymbolKind == UndefinedDataKind || SymbolKind == UndefinedGlobalKind;
   }
+
+  bool isLazy() const { return SymbolKind == LazyKind; }
+
   bool isLocal() const;
   bool isWeak() const;
   bool isHidden() const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43711.135764.patch
Type: text/x-patch
Size: 1033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180224/3e877259/attachment.bin>