[PATCH] D43669: [cfi] Lazy CFI initialization

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 18:36:35 PST 2018


eugenis accepted this revision.
eugenis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/cfi/cfi.cc:416
-  INTERCEPT_FUNCTION(dlclose);
-
 #ifdef CFI_ENABLE_DIAG
----------------
eugenis wrote:
> eugenis wrote:
> > This is technically a data race. Let's just take a lock, this is not performance sensitive.
> call EnsureInterceptorsInitialized() here, or it may become a surprise if someone adds a new interceptor without that check
I see, that's too early for that.


https://reviews.llvm.org/D43669





More information about the llvm-commits mailing list