[PATCH] D42712: [utils] Add utils/update_cc_test_checks.py

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Start of some comment requests.



================
Comment at: utils/UpdateTestChecks/asm.py:97
   asm = SCRUB_X86_LCP_RE.sub(r'{{\.LCPI.*}}', asm)
-  if args.x86_extra_scrub:
+  if getattr(args, 'x86_extra_scrub', False):
     # Avoid generating different checks for 32- and 64-bit because of 'retl' vs 'retq'.
----------------
Hmm?


================
Comment at: utils/UpdateTestChecks/common.py:32
   with open(ir) as ir_file:
-    stdout = subprocess.check_output(exe + ' ' + cmd_args,
-                                     shell=True, stdin=ir_file)
+    if isinstance(cmd_args, list):
+      stdout = subprocess.check_output([exe] + cmd_args, stdin=ir_file)
----------------
Can you comment this change?


================
Comment at: utils/update_cc_test_checks.py:189
+
+    # Execute clang, generate assembly, and extract functions.
+    func_dict = {}
----------------
Update comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D42712