[PATCH] D43698: Plug errno in TCPSocket::Connect()

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:55:45 PST 2018


labath added a comment.

This seems weird. I have never seen anyone resetting errno *after* a call. Wouldn't it be better to log strerror(errno) somewhere, or make sure that the Status object reflects the actual error?


Repository:
  rL LLVM

https://reviews.llvm.org/D43698





More information about the llvm-commits mailing list