[PATCH] D43642: [ELF] Add comment for preemptible and fix typo. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:02:02 PST 2018


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: ELF/Symbols.h:157
 
+  // True if this symbol is preemptible at link or load time.
   unsigned IsPreemptible : 1;
----------------
ruiu wrote:
> Is this correct? I thought IsPreemptible=true means the symbol is preemptible at load time. I don't think "a symbol preemptible at link time" is a well defined concept.
Fixed in the latest commit. I did not know that I can commit when this revision was in the "Need review" status. I saw a LGTM on my phone.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43642





More information about the llvm-commits mailing list