[PATCH] D42765: [DebugInfo] Support DWARFv5 source code embedding extension

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Other than the one small nit about the `\brief` I have no complaints. So LGTM, but maybe give the others a chance to review this before landing.



================
Comment at: include/llvm/MC/MCDwarf.h:60
+
+  // \brief The source code of the file. Non-owning reference to data allocated
+  // in MCContext.
----------------
We omit the brief for new/updated code as autobrief is now enabled.


================
Comment at: include/llvm/MC/MCStreamer.h:755
 
-  /// \brief Associate a filename with a specified logical file number.  This
-  /// implements the DWARF2 '.file 4 "foo.c"' assembler directive.
+  /// \brief Associate a filename with a specified logical file number.
+  /// Also associate a directory, optional checksum, and optional source
----------------
Same here


https://reviews.llvm.org/D42765