[PATCH] D43208: [LV][nearly NFC] Move isLegalMasked* functions from Legality to CostModel

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6202
 
+  if (!EnableCondStoresVectorization && NumPredStores) {
+    ORE->emit(createMissedAnalysis("ConditionalStore")
----------------
hsaito wrote:
> Do we even want to keep this bail out? 
I think this is done more as diagnosis than bail out.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6586
 
+bool LoopVectorizationCostModel::useEmulatedMaskMemRefHack(Instruction *I){
+  // TODO: Cost model for emulated masked load/store is completely
----------------
What if this was a hook into the TTI, it could use the targets' information to get a slightly more accurate cost estimate (ie, how hacky is the emulation, or even if one is available through its back-end)


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6588
+  // TODO: Cost model for emulated masked load/store is completely
+  // broken. This hack guides the cost model to use an artificially high
+  // high enough value to practically disable vectorization with such
----------------
high / high


Repository:
  rL LLVM

https://reviews.llvm.org/D43208