[PATCH] D42967: [ARM] Fix PR36249: add expansion rule for VLD1d64 pseudo with reg WB

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 02:40:36 PST 2018

thopre added a comment.

Hi Sam,

Code generation for these pseudo is already checked by the follow-on patch in https://reviews.llvm.org/D42970 (the very testcase that triggered the need for this present fix). I feel that adding checks here again would mean more testcases need to be updated in case code generation for these pseudo instructions needs to be changed. I also feel it brings a nice separation of concern: one test checks code generation, one checks correct expansion / absence of assert failure.

If you disagree let me know and I'll add the check right away.



More information about the llvm-commits mailing list