[PATCH] D43561: TableGen: Avoid using resolveListElementReference in TGParser

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 15:01:11 PST 2018


tra added a comment.

In https://reviews.llvm.org/D43561#1016560, @nhaehnle wrote:

> Are you sure? The whole point of splitting it out is that it can be changed separately, and if it breaks something a bisect result will be more helpful. I've tested this quite thoroughly so I don't think it does break anything, but still... seems like a waste to merge it back in. Maybe I'm just too used to the old-school Git way of doing things.


On its own this change is rather non-obvious. It makes whole lot more sense (to me at least) in the context of removing resolveListElementReference().

I'm fine keeping the patches separate, as long as this patch comes with an adequate description of what's going on.

In https://reviews.llvm.org/D43561#1016557, @nhaehnle wrote:

> Better summary.


I don't see any changes.  The summary is still empty and there are no changes to the files.


Repository:
  rL LLVM

https://reviews.llvm.org/D43561





More information about the llvm-commits mailing list