[PATCH] D42516: [llvm-objcopy] Add support for large indexes

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 12:46:40 PST 2018


The string table is very small. The symbols and sections all have the same
name. It's also highly compressible which means I can upload it via svn and
then use the same binary in multiple tests without incurring the cost of
regenerating the same sort of large binary for every test. On my system the
generation of the binary using assembly macros takes 3 seconds. Over 7-8
tests that adds up. It would increase overall test running times by a few
percent at least (probably more like 8% for most people). LLD only has one
test of this sort so it isn't a big deal.

On Thu, Feb 22, 2018, 12:21 PM Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Jake Ehrlich via Phabricator via llvm-commits
> <llvm-commits at lists.llvm.org> writes:
>
> > jakehehrlich added a comment.
> >
> > In https://reviews.llvm.org/D42516#1015427, @emaste wrote:
> >
> >> In https://reviews.llvm.org/D42516#1015414, @jakehehrlich wrote:
> >>
> >> > You can download the zip file that I'm using here:
> https://drive.google.com/file/d/1u6W1mUHkFBPsLzEV4u50M_BeiPKMyipM/view?usp=sharing
> >>
> >>
> >> Thanks for this. It demonstrates some particularly poor behaviour in
> ELF Tool Chain's elfcopy (so, if anyone's comparing objcopy versions,
> there's not much value in including ELF Tool Chain right now).
> >
> >
> > I had to commit many atrocities to make that file. I actually have a
> desire for a yaml2obj like tool that would let me construct ELFs more
> succinctly. That binary was produced by getting as close as I could with a
> generated .s and then using many different tools to tweak the results. It
> wasn't pretty.
>
> Out of curiosity, what properties does it have in addition to what lld's
> many-sections.s provide?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/92542b80/attachment.html>


More information about the llvm-commits mailing list