[PATCH] D43595: WIP alternative to r325686 (Implement name based structure type mapping).

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola abandoned this revision.
espindola added a comment.

I found a fundamental issue with this:

void ConstantExpr::destroyConstantImpl() {

  getType()->getContext().pImpl->ExprConstants.remove(this);

}

Which means we cannot mutate the type without also rebuilding the constant uniquing tables.

I am out of ideas that are no really expensive like implementing a move constructor on Module and always starting the linker with an empty module.

I guess we really need to finish the changes for having a single pointer type.

I will LGTM the original change and ask for a second review on it in case someone has a better idea.


https://reviews.llvm.org/D43595