[PATCH] D43624: Change DEBUG() macro to LLVM_DEBUG()

Nicola Zaghen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 08:29:23 PST 2018 

Nicola created this revision.
Nicola added a reviewer: zturner.
Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists, simoncook, haicheng, johnrusso, rbar, asb, javed.absar, kuhar, JDevlieghere, kbarton, aheejin, eraman, jgravelle-google, sbc100, nhaehnle, david2050, nemanjai, jfb, sdardis, mehdi_amini, dylanmckay, dschuff, arsenm, sanjoy, qcolombet, MatzeB, jholewinski.

The DEBUG() macro is too generic so it might clash with other projects.
I noticed in include/llvm/DebugInfo/PDB/DIA/DIASupport.h a comment expressing interest in changing DEBUG() to LLVM_DEBUG() so I decided to give it a go.

This is the command I used to do the replacement:
git grep -l 'DEBUG' | xargs sed -i 's/\bDEBUG\s\?(/LLVM_DEBUG(/g'

Then I manually adjusted the DEBUG macro push/pop uses in APInt.cpp and DIASupport.h


Repository:
  rL LLVM

https://reviews.llvm.org/D43624

Files:
  docs/Bugpoint.rst
  docs/CommandGuide/opt.rst
  docs/CommandLine.rst
  docs/ProgrammersManual.rst
  include/llvm/Analysis/BlockFrequencyInfoImpl.h
  include/llvm/Analysis/CGSCCPassManager.h
  include/llvm/Analysis/RegionInfoImpl.h
  include/llvm/Analysis/SparsePropagation.h
  include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
  include/llvm/DebugInfo/PDB/DIA/DIASupport.h
  include/llvm/ExecutionEngine/Orc/OrcRemoteTargetClient.h
  include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
  include/llvm/Support/Debug.h
  include/llvm/Support/GenericDomTreeConstruction.h
  include/llvm/Support/UnicodeCharRanges.h
  include/llvm/Transforms/InstCombine/InstCombineWorklist.h
  include/llvm/Transforms/Utils/SSAUpdaterImpl.h
  lib/Analysis/BlockFrequencyInfoImpl.cpp
  lib/Analysis/BranchProbabilityInfo.cpp
  lib/Analysis/CFLAndersAliasAnalysis.cpp
  lib/Analysis/CFLSteensAliasAnalysis.cpp
  lib/Analysis/CGSCCPassManager.cpp
  lib/Analysis/CallGraphSCCPass.cpp
  lib/Analysis/CodeMetrics.cpp
  lib/Analysis/DemandedBits.cpp
  lib/Analysis/DependenceAnalysis.cpp
  lib/Analysis/IVUsers.cpp
  lib/Analysis/IndirectCallPromotionAnalysis.cpp
  lib/Analysis/InlineCost.cpp
  lib/Analysis/LazyCallGraph.cpp
  lib/Analysis/LazyValueInfo.cpp
  lib/Analysis/LoopAccessAnalysis.cpp
  lib/Analysis/LoopPass.cpp
  lib/Analysis/MemoryBuiltins.cpp
  lib/Analysis/MemoryDependenceAnalysis.cpp
  lib/Analysis/MemorySSA.cpp
  lib/Analysis/RegionPass.cpp
  lib/Analysis/ScalarEvolution.cpp
  lib/CodeGen/AggressiveAntiDepBreaker.cpp
  lib/CodeGen/AllocationOrder.cpp
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/CodeGen/AsmPrinter/DIEHash.cpp
  lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AtomicExpandPass.cpp
  lib/CodeGen/BranchFolding.cpp
  lib/CodeGen/BranchRelaxation.cpp
  lib/CodeGen/BreakFalseDeps.cpp
  lib/CodeGen/CalcSpillWeights.cpp
  lib/CodeGen/CodeGenPrepare.cpp
  lib/CodeGen/CriticalAntiDepBreaker.cpp
  lib/CodeGen/DFAPacketizer.cpp
  lib/CodeGen/DeadMachineInstructionElim.cpp
  lib/CodeGen/DetectDeadLanes.cpp
  lib/CodeGen/EarlyIfConversion.cpp
  lib/CodeGen/ExecutionDomainFix.cpp
  lib/CodeGen/ExpandPostRAPseudos.cpp
  lib/CodeGen/FaultMaps.cpp
  lib/CodeGen/GlobalISel/Combiner.cpp
  lib/CodeGen/GlobalISel/IRTranslator.cpp
  lib/CodeGen/GlobalISel/InstructionSelect.cpp
  lib/CodeGen/GlobalISel/Legalizer.cpp
  lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  lib/CodeGen/GlobalISel/Localizer.cpp
  lib/CodeGen/GlobalISel/RegBankSelect.cpp
  lib/CodeGen/GlobalISel/RegisterBankInfo.cpp
  lib/CodeGen/GlobalISel/Utils.cpp
  lib/CodeGen/GlobalMerge.cpp
  lib/CodeGen/IfConversion.cpp
  lib/CodeGen/InlineSpiller.cpp
  lib/CodeGen/InterleavedAccessPass.cpp
  lib/CodeGen/LazyMachineBlockFrequencyInfo.cpp
  lib/CodeGen/LiveDebugValues.cpp
  lib/CodeGen/LiveDebugVariables.cpp
  lib/CodeGen/LiveIntervals.cpp
  lib/CodeGen/LiveRangeEdit.cpp
  lib/CodeGen/LiveRangeShrink.cpp
  lib/CodeGen/LiveRegMatrix.cpp
  lib/CodeGen/LocalStackSlotAllocation.cpp
  lib/CodeGen/MIRCanonicalizerPass.cpp
  lib/CodeGen/MachineBasicBlock.cpp
  lib/CodeGen/MachineBlockPlacement.cpp
  lib/CodeGen/MachineCSE.cpp
  lib/CodeGen/MachineCombiner.cpp
  lib/CodeGen/MachineCopyPropagation.cpp
  lib/CodeGen/MachineFrameInfo.cpp
  lib/CodeGen/MachineLICM.cpp
  lib/CodeGen/MachineOutliner.cpp
  lib/CodeGen/MachinePipeliner.cpp
  lib/CodeGen/MachineRegionInfo.cpp
  lib/CodeGen/MachineSSAUpdater.cpp
  lib/CodeGen/MachineScheduler.cpp
  lib/CodeGen/MachineSink.cpp
  lib/CodeGen/MachineTraceMetrics.cpp
  lib/CodeGen/MacroFusion.cpp
  lib/CodeGen/PHIElimination.cpp
  lib/CodeGen/PeepholeOptimizer.cpp
  lib/CodeGen/PostRASchedulerList.cpp
  lib/CodeGen/ProcessImplicitDefs.cpp
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/CodeGen/ReachingDefAnalysis.cpp
  lib/CodeGen/RegAllocBase.cpp
  lib/CodeGen/RegAllocBasic.cpp
  lib/CodeGen/RegAllocFast.cpp
  lib/CodeGen/RegAllocGreedy.cpp
  lib/CodeGen/RegAllocPBQP.cpp
  lib/CodeGen/RegUsageInfoCollector.cpp
  lib/CodeGen/RegUsageInfoPropagate.cpp
  lib/CodeGen/RegisterClassInfo.cpp
  lib/CodeGen/RegisterCoalescer.cpp
  lib/CodeGen/RegisterScavenging.cpp
  lib/CodeGen/RenameIndependentSubregs.cpp
  lib/CodeGen/ResetMachineFunctionPass.cpp
  lib/CodeGen/SafeStack.cpp
  lib/CodeGen/SafeStackColoring.cpp
  lib/CodeGen/SafeStackLayout.cpp
  lib/CodeGen/ScheduleDAGInstrs.cpp
  lib/CodeGen/ScoreboardHazardRecognizer.cpp
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/FastISel.cpp
  lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
  lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp
  lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
  lib/CodeGen/SelectionDAG/ScheduleDAGVLIW.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp
  lib/CodeGen/ShrinkWrap.cpp
  lib/CodeGen/SjLjEHPrepare.cpp
  lib/CodeGen/SlotIndexes.cpp
  lib/CodeGen/SplitKit.cpp
  lib/CodeGen/StackColoring.cpp
  lib/CodeGen/StackMapLivenessAnalysis.cpp
  lib/CodeGen/StackMaps.cpp
  lib/CodeGen/StackSlotColoring.cpp
  lib/CodeGen/TailDuplicator.cpp
  lib/CodeGen/TargetRegisterInfo.cpp
  lib/CodeGen/TwoAddressInstructionPass.cpp
  lib/CodeGen/VirtRegMap.cpp
  lib/CodeGen/WinEHPrepare.cpp
  lib/ExecutionEngine/ExecutionEngine.cpp
  lib/ExecutionEngine/Interpreter/Execution.cpp
  lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp
  lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFI386.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.cpp
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOI386.h
  lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOX86_64.h
  lib/IR/ConstantsContext.h
  lib/IR/Core.cpp
  lib/IR/Pass.cpp
  lib/IR/SafepointIRVerifier.cpp
  lib/IR/ValueSymbolTable.cpp
  lib/LTO/ThinLTOCodeGenerator.cpp
  lib/MC/MachObjectWriter.cpp
  lib/MC/WasmObjectWriter.cpp
  lib/Object/WasmObjectFile.cpp
  lib/ProfileData/Coverage/CoverageMapping.cpp
  lib/ProfileData/Coverage/CoverageMappingReader.cpp
  lib/Support/APInt.cpp
  lib/Support/CachePruning.cpp
  lib/Support/CommandLine.cpp
  lib/Support/DAGDeltaAlgorithm.cpp
  lib/Support/Debug.cpp
  lib/Support/RandomNumberGenerator.cpp
  lib/Target/AArch64/AArch64A53Fix835769.cpp
  lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp
  lib/Target/AArch64/AArch64AdvSIMDScalarPass.cpp
  lib/Target/AArch64/AArch64CollectLOH.cpp
  lib/Target/AArch64/AArch64CondBrTuning.cpp
  lib/Target/AArch64/AArch64ConditionOptimizer.cpp
  lib/Target/AArch64/AArch64ConditionalCompares.cpp
  lib/Target/AArch64/AArch64DeadRegisterDefinitionsPass.cpp
  lib/Target/AArch64/AArch64FalkorHWPFFix.cpp
  lib/Target/AArch64/AArch64FrameLowering.cpp
  lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64InstructionSelector.cpp
  lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
  lib/Target/AArch64/AArch64PBQPRegAlloc.cpp
  lib/Target/AArch64/AArch64PromoteConstant.cpp
  lib/Target/AArch64/AArch64RedundantCopyElimination.cpp
  lib/Target/AArch64/AArch64StorePairSuppress.cpp
  lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  lib/Target/AMDGPU/AMDGPUInline.cpp
  lib/Target/AMDGPU/AMDGPULibCalls.cpp
  lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
  lib/Target/AMDGPU/AMDGPUOpenCLEnqueuedBlockLowering.cpp
  lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
  lib/Target/AMDGPU/AMDGPURewriteOutArguments.cpp
  lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
  lib/Target/AMDGPU/AMDILCFGStructurizer.cpp
  lib/Target/AMDGPU/GCNILPSched.cpp
  lib/Target/AMDGPU/GCNIterativeScheduler.cpp
  lib/Target/AMDGPU/GCNMinRegStrategy.cpp
  lib/Target/AMDGPU/GCNSchedStrategy.cpp
  lib/Target/AMDGPU/R600ClauseMergePass.cpp
  lib/Target/AMDGPU/R600ControlFlowFinalizer.cpp
  lib/Target/AMDGPU/R600MachineScheduler.cpp
  lib/Target/AMDGPU/R600OptimizeVectorRegisters.cpp
  lib/Target/AMDGPU/R600Packetizer.cpp
  lib/Target/AMDGPU/SIAnnotateControlFlow.cpp
  lib/Target/AMDGPU/SIFixSGPRCopies.cpp
  lib/Target/AMDGPU/SIFixVGPRCopies.cpp
  lib/Target/AMDGPU/SIFoldOperands.cpp
  lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  lib/Target/AMDGPU/SIInsertWaits.cpp
  lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
  lib/Target/AMDGPU/SIMachineScheduler.cpp
  lib/Target/AMDGPU/SIOptimizeExecMasking.cpp
  lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
  lib/Target/AMDGPU/SIPeepholeSDWA.cpp
  lib/Target/AMDGPU/SIShrinkInstructions.cpp
  lib/Target/AMDGPU/SIWholeQuadMode.cpp
  lib/Target/ARC/ARCBranchFinalize.cpp
  lib/Target/ARC/ARCFrameLowering.cpp
  lib/Target/ARC/ARCISelLowering.cpp
  lib/Target/ARC/ARCInstrInfo.cpp
  lib/Target/ARC/ARCRegisterInfo.cpp
  lib/Target/ARC/Disassembler/ARCDisassembler.cpp
  lib/Target/ARM/A15SDOptimizer.cpp
  lib/Target/ARM/ARMBaseInstrInfo.cpp
  lib/Target/ARM/ARMBaseRegisterInfo.cpp
  lib/Target/ARM/ARMConstantIslandPass.cpp
  lib/Target/ARM/ARMFrameLowering.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMInstructionSelector.cpp
  lib/Target/ARM/ARMLoadStoreOptimizer.cpp
  lib/Target/ARM/ARMTargetTransformInfo.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/MLxExpansionPass.cpp
  lib/Target/ARM/Thumb2SizeReduction.cpp
  lib/Target/AVR/AVRISelDAGToDAG.cpp
  lib/Target/AVR/AsmParser/AVRAsmParser.cpp
  (242 more files...)

More information about the llvm-commits mailing list