[PATCH] D43553: TableGen: Add !size operation

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: docs/TableGen/LangRef.rst:101
                :!or     !empty   !subst   !foreach   !strconcat
-               :!cast   !listconcat
+               :!cast   !listconcat       !size
 
----------------
tra wrote:
> It would be good to add more details about !size in docs/TableGen/LangIntro.rst
Done.


================
Comment at: test/TableGen/size.td:6-20
+// CHECK: def A1 {
+// CHECK:   int Val = 0;
+// CHECK: }
+
+// CHECK: def A2 {
+// CHECK:   int Val = 3;
+// CHECK: }
----------------
tra wrote:
> I'd interleave those with the `def An:...` below.
I'd prefer to leave it as-is. Unlike other tools, TableGen output is not in the order of the input file but sorted alphabetically, so I find interleaving the CHECK lines misleading. I think it's easier to work with this way.


Repository:
  rL LLVM

https://reviews.llvm.org/D43553