[PATCH] D43080: Adding Msan support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: test/msan/pthread_getname_np.cc:2
 // RUN: %clangxx_msan -std=c++11 -O0 %s -o %t && %run %t
-// UNSUPPORTED: android, netbsd
+// pthread_getattr_np unavailable on freebsd 
+// UNSUPPORTED: android, netbsd, freebsd
----------------
`getname`?


================
Comment at: test/msan/strlen_of_shadow.cc:5
 // memory.
+// UNSUPPORTED: freebsd
 
----------------
krytarowski wrote:
> What's wrong here?
This is a bold comment.


================
Comment at: test/msan/textdomain.cc:2
 // RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
+// Would need passing specific flags for *BSD systems
 // UNSUPPORTED: netbsd, freebsd
----------------
I propose to document here that `textdomain() is not a part of libc on FreeBSD and NetBSD.`


https://reviews.llvm.org/D43080