[PATCH] D42834: [RISCV] Implement c.lui immedate operand constraint

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 03:21:14 PST 2018


asb added a comment.

Only remaining concern:

RISCVMCCodeEmitter::getCLUIImmOpValue doesn't seem to be necessary - or at least, modifying c_lui_imm so it doesn't use a custom EncoderMethod still results in all tests passing. From my understanding of the code, I think the custom getCLUImmOpValue isn't necessary and can be removed. If I'm missing something and it is necessary, then the tests should be updated so they fail without it.


Repository:
  rL LLVM

https://reviews.llvm.org/D42834





More information about the llvm-commits mailing list