[PATCH] D43601: [bugpoint] Add NoStripSymbols option.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Okay reading the code a bit more seems like that is what you are doing.

In https://reviews.llvm.org/D43601#1015404, @MatzeB wrote:

> But we don't want user flags for bugpoint, we want it to try both variants and keep the smaller one when it still reproduces the crash.


Okay reading the code some more, it seems like that is what you are doing here and the option is just to disable the extra try.

- You should split the `OptionCategory` changes into a separate commit.
- I suspect a lot of this code is duplicated with the `-strip` pass, would it be possible to refactor it into a utility function used by both?



================
Comment at: tools/bugpoint/CrashDebugger.cpp:103
+
+  for (unsigned i = 0, e = StructTypes.size(); i != e; ++i) {
+    StructType *STy = StructTypes[i];
----------------
maybe this can use a ranged for too? Similar for many of the other for loops.


Repository:
  rL LLVM

https://reviews.llvm.org/D43601