[lld] r325714 - Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423)

[Rafael Avila de Espindola via llvm-commits]

For the record, I agree with Rui.

So far the only known cases are in two repositories controlled by
OpenBSD. If that is really the case, switching to the more common
spelling seems the best solution.

Cheers,
Rafael

Rui Ueyama via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Author: ruiu
> Date: Wed Feb 21 12:08:14 2018
> New Revision: 325714
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325714&view=rev
> Log:
> Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423)
>
> This reverts commit r325679 that was committed without discussion.
> Actually, in the discussion thread, most people opposed to have this
> option in lld. Reverting that change doesn't mean that this is a
> final decision, but that needs to be discussed first.
>
> Modified:
>     lld/trunk/ELF/Options.td
>     lld/trunk/test/ELF/pie.s
>
> Modified: lld/trunk/ELF/Options.td
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=325714&r1=325713&r2=325714&view=diff
> ==============================================================================
> --- lld/trunk/ELF/Options.td (original)
> +++ lld/trunk/ELF/Options.td Wed Feb 21 12:08:14 2018
> @@ -358,7 +358,6 @@ def alias_format_b: S<"b">, Alias<format
>  def alias_library: JoinedOrSeparate<["-"], "l">, Alias<library>;
>  def alias_library_path: JoinedOrSeparate<["-"], "L">, Alias<library_path>;
>  def alias_no_pie_pic_executable: F<"no-pic-executable">, Alias<no_pie>;
> -def alias_nopie: F<"nopie">, Alias<no_pie>;
>  def alias_omagic: Flag<["-"], "N">, Alias<omagic>;
>  def alias_o_output: Joined<["--"], "output=">, Alias<o>;
>  def alias_o_output2 : Separate<["--"], "output">, Alias<o>;
>
> Modified: lld/trunk/test/ELF/pie.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/pie.s?rev=325714&r1=325713&r2=325714&view=diff
> ==============================================================================
> --- lld/trunk/test/ELF/pie.s (original)
> +++ lld/trunk/test/ELF/pie.s Wed Feb 21 12:08:14 2018
> @@ -47,11 +47,9 @@
>  
>  # CHECK:         Type: PT_DYNAMIC
>  
> -## Check -no-pie
> +## Check -nopie
>  # RUN: ld.lld -no-pie %t1.o -o %t2
>  # RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
> -# RUN: ld.lld -nopie %t1.o -o %t2
> -# RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
>  # RUN: ld.lld -no-pic-executable %t1.o -o %t2
>  # RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
>  # NOPIE-NOT: Type: SharedObject
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits