[PATCH] D43603: [utils] fixing update_mir_test_checks.py's greediness for `registers:` field

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 17:12:14 PST 2018


rtereshin created this revision.
rtereshin added a reviewer: bogner.
Herald added a subscriber: javed.absar.

utils/update_mir_test_checks.py may cross machine function boundaries while parsing a *.mir test looking for `registers:` YAML-field a little too greedily than it actually needs. If there is a MF w/o `registers:` field followed by a MF with one it will parse both of them with the name of the first one, and registers and body of the second one and eventually crash.

This patch also adds a LIT-test for utils/update_mir_test_checks.py itself to ensure we don't regress on this or, frankly, anything else.


Repository:
  rL LLVM

https://reviews.llvm.org/D43603

Files:
  test/CodeGen/AArch64/test-update_mir_test_checks.py-itself.mir
  utils/update_mir_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43603.135349.patch
Type: text/x-patch
Size: 4856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/ce025b72/attachment.bin>


More information about the llvm-commits mailing list