[PATCH] D41364: move UseDwarfRangesBaseAddressSpecifier to front end flag

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 14:44:26 PST 2018


echristo added inline comments.


================
Comment at: include/llvm/MC/MCTargetOptions.h:66
+  /// Enable base address specification in dwarf ranges 
+  bool UseDwarfRangesBaseAddressSpecifier;
+
----------------
Might want to put this bool up near the other bools.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:88-90
+// static cl::opt<bool> UseDwarfRangesBaseAddressSpecifier(
+//     "use-dwarf-ranges-base-address-specifier", cl::Hidden,
+//     cl::desc("Use base address specifiers in debug_ranges"), cl::init(false));
----------------
Typically we don't comment things out. :)


https://reviews.llvm.org/D41364





More information about the llvm-commits mailing list